fix(core/chip, pill): removed default left margin from chip pill#2309
fix(core/chip, pill): removed default left margin from chip pill#2309GayatriK2002 wants to merge 7 commits intosiemens:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e126e92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @GayatriK2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the flexibility of the 'ix-chip' and 'ix-pill' components by eliminating their default left margins. This change allows developers greater control over component spacing and alignment. To ensure visual consistency and prevent regressions, the corresponding visual test cases have been updated to explicitly apply the previously implicit margins, maintaining the intended appearance of these components in their test environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the default left margin from the chip and pill components, which is a good change to give consumers more control over layout. The related updates to the visual regression tests are mostly fine, but I've found an opportunity to improve the maintainability of one of the test files (testing/visual-testing/tests/pill/basic/index.html). Instead of using a combination of text-align: center and removing whitespace between elements with ><, I've suggested using display: flex with the gap property, which is a cleaner and more modern approach for layout spacing.
|
2 participants
💡 What is the current behavior?
GitHub Issue Number: #
Jira Issue Number: 3178
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support